[On Hold] Generate Brotli files #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 12, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
|
From the Brotli PR it seems like they only supported receiving requests using brotli. It doesn't seem like they will sent brotli compressed files. To add that, we should add similar code as this gzip PR for aiohttp. |
|
Ran some numbers out of curiosity:
|
|
Note that when it comes to compressing for the web, besides the final size, the CPU needed for decompression matters too. |
|
Can we close this PR?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Brotli files